Ilmari Karonen [Tue, 8 Mar 2011 15:54:28 +0000 (15:54 +0000)]
revert r83521; this needs to be fixed better, but fixing the crash is first priority
Mark A. Hershberger [Tue, 8 Mar 2011 14:38:26 +0000 (14:38 +0000)]
followup r76127 — use language-aware comparison between link text and possible title attribute
Max Semenik [Tue, 8 Mar 2011 09:28:13 +0000 (09:28 +0000)]
LocalSettings generation tweaks:
* Mention extensions only if user chose some during installation
* Added a comment at the bottom suggesting where to put new settings
Antoine Musso [Tue, 8 Mar 2011 07:27:18 +0000 (07:27 +0000)]
switch 'column' for 'colon'
I always thought the colon and semicolon punctuation marks were named after
their architectural equivalent: column. At least, to me, it made more sens
than using a term relating to thedigestive system.
Per Nikerabbit r83296
Tim Starling [Tue, 8 Mar 2011 06:38:15 +0000 (06:38 +0000)]
Set $wgInternalServer to false by default, and fall back to $wgServer in the referring code. This avoids having squid updates break when $wgServer is set in configuration but $wgInternalServer is neglected. For immediate deployment, tested locally.
Sam Reed [Tue, 8 Mar 2011 02:40:09 +0000 (02:40 +0000)]
Last few svn property fixes
Sam Reed [Tue, 8 Mar 2011 02:25:12 +0000 (02:25 +0000)]
And some more mime-types
Trevor Parscal [Tue, 8 Mar 2011 02:02:27 +0000 (02:02 +0000)]
* Increased the size of the tipsy callout, removed the shadow and made the background of tips white to try and improve the visibility of tips.
* Added ui-button-green, ui-button-blue, ui-button-red classes to the Vector jquery ui theme
Platonides [Tue, 8 Mar 2011 00:20:26 +0000 (00:20 +0000)]
Comment the var_dump() and add a comment.
Follow up r83208.
Sam Reed [Mon, 7 Mar 2011 22:58:26 +0000 (22:58 +0000)]
Fix r83390, need to do where ipb_deleted IS NULL as we're left joining in the table, so it can be null
Duh
Krinkle [Mon, 7 Mar 2011 21:17:47 +0000 (21:17 +0000)]
removing fallback, not needed (messages are in-core and defined in Resources.php). FU: r78966
Sam Reed [Mon, 7 Mar 2011 20:42:55 +0000 (20:42 +0000)]
Strip cookie classes out of the middle of HttpFunctions.php into Cookie.php using svn copy
Raimond Spekking [Mon, 7 Mar 2011 20:21:17 +0000 (20:21 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-07 19:38:00 UTC)
Raimond Spekking [Mon, 7 Mar 2011 20:03:32 +0000 (20:03 +0000)]
Follow-up r83292/r83310: Add new message to the maintenance file too
Platonides [Mon, 7 Mar 2011 19:13:19 +0000 (19:13 +0000)]
Merge corrected r81741 and resolve the TODO.
Keep disabled with a class constant.
Max Semenik [Mon, 7 Mar 2011 18:45:43 +0000 (18:45 +0000)]
Bug 27920 - Installer sets $wgUseImageMagick = true even when IM is not found
Alexandre Emsenhuber [Mon, 7 Mar 2011 18:21:58 +0000 (18:21 +0000)]
* Make Skin::formatDebugHTML() work with $wgDebugTimestamps = true
* Removed escaping of ' since the string is defined with "
Bryan Tong Minh [Mon, 7 Mar 2011 17:17:57 +0000 (17:17 +0000)]
Follow-up r83461, replace deleted with hidden and reverse the word, e.g. deletedfile->filehidden. Consistency with prop=revision etc. (In Soviet-Russia, file hides you!)
Antoine Musso [Mon, 7 Mar 2011 17:10:22 +0000 (17:10 +0000)]
Remove second parameters from wfEmptyMsg() calls
The second parameter was removed in r64178 and is now useless.
There is probably no need to backport this in 1.17.
Bryan Tong Minh [Mon, 7 Mar 2011 17:07:10 +0000 (17:07 +0000)]
(bug 27722) list=filearchive now supports revdel
* Adds a condition fa_deleted=0 if the user does not have the suppressrevision rights. This field is unindexed. This should however not be a big problem as files with fa_deleted are rare. Unfortunately this hides files that do not have DELETED_RESTRICTED, but I don't know how bad fa_deleted & DELETED_RESTRICTED = 0 is for performance
* Added deletedfile, deletedcomment, deleteduser and deletedrestricted to the output for what I think are appropriate fa_deleted fields, but it's hard to tell what's corrent without a single line of documentation or even comment in the code. Perhaps somebody can dig up a commit message where the purpose of the constants is explained?
Antoine Musso [Mon, 7 Mar 2011 16:36:35 +0000 (16:36 +0000)]
Keep monospace as a fallback for HTML debugging
Per CR on r83336. We also keep this as inline style since it is only
needed by developers anyway.
Sam Reed [Mon, 7 Mar 2011 14:59:41 +0000 (14:59 +0000)]
More documentation
Remove trailing whitespace
Sam Reed [Mon, 7 Mar 2011 14:45:11 +0000 (14:45 +0000)]
Documentation and explicit variable definitions
Followup r80069, swap private to protected
Siebrand Mazeland [Mon, 7 Mar 2011 12:13:14 +0000 (12:13 +0000)]
Rephrase 'config-using531' per suggestion of Krinkle: "Granted the bug is in PHP, but imho "PHP" isn't compatible with MediaWiki, it's the other way around."
Also removed the link to the PHP bug report. Not that relevant for the user installing MediaWiki.
Platonides [Sun, 6 Mar 2011 23:29:29 +0000 (23:29 +0000)]
Reorder so that wfProfileOut() is the last sentence before the return.
Platonides [Sun, 6 Mar 2011 23:28:32 +0000 (23:28 +0000)]
Remove unused globals
Krinkle [Sun, 6 Mar 2011 23:25:33 +0000 (23:25 +0000)]
Fix for IE7, jQuery magic doesn't help here, it needs to be valid html, shorthand doesn't work in all browsers
Platonides [Sun, 6 Mar 2011 23:15:10 +0000 (23:15 +0000)]
r82867 converted $wgCaches into a class instance. Update the parsertests.
This faking is needed to avoid Table 'unittest_objectcache' doesn't exist errors when using temporary tables.
Platonides [Sun, 6 Mar 2011 23:07:36 +0000 (23:07 +0000)]
Follow up r83140. Add a clear() method to ObjectCache so that it can be used by ForkController.
Bryan Tong Minh [Sun, 6 Mar 2011 22:16:34 +0000 (22:16 +0000)]
Kill filtering by hash because the query is unindexed. We need a condition on fa_storage_group, but I'm not sure how index merging will work out. I don't have time to investigate this at the moment, so killing it in its entirety seems the safest option for now.
Bryan Tong Minh [Sun, 6 Mar 2011 22:03:45 +0000 (22:03 +0000)]
Breaking change: remove faminsize/famaxsize because they lead to an unindexed query, which takes a very long time if there are only few rows that match the filter. Introduced in r66168, so luckily only live since 1.17.
Platonides [Sun, 6 Mar 2011 21:51:21 +0000 (21:51 +0000)]
Add $namespaceGenderAliases support to Spanish. Part of bug 27691.
Alexandre Emsenhuber [Sun, 6 Mar 2011 21:16:22 +0000 (21:16 +0000)]
Only call ParserOptions::getNumberHeadings() when needed for the benefit of cache sharing when this is not used.
Also fixed a bug in ParserOutput when no option is used; otherwise getUsedOptions() will return false and throw warnings in ParserOptions::optionsHash().
Alexandre Emsenhuber [Sun, 6 Mar 2011 21:05:18 +0000 (21:05 +0000)]
* Added UserGetLanguageObject hook to change the language used in $wgLang
Antoine Musso [Sun, 6 Mar 2011 21:01:54 +0000 (21:01 +0000)]
Script to purge all pages of a given namespace
Sam Reed [Sun, 6 Mar 2011 20:51:31 +0000 (20:51 +0000)]
Followup r83390
If the user is allowed to view hidden users, put a missing property on all users.
For list=users, do the same, but we can't easily distinguish to other people the difference between "hidden", or "missing", so no reason to do it
Sam Reed [Sun, 6 Mar 2011 20:38:00 +0000 (20:38 +0000)]
Fix where ipb_deleted from r83390
Sam Reed [Sun, 6 Mar 2011 20:20:24 +0000 (20:20 +0000)]
Followup r83399, add back base conversion
Chad Horohoe [Sun, 6 Mar 2011 20:14:12 +0000 (20:14 +0000)]
(bug 17691) Support CC0 license in installer
Sam Reed [Sun, 6 Mar 2011 20:05:41 +0000 (20:05 +0000)]
* (bug 27588) list=filearchive&faprop=sha1 returns empty attribute
Refactored code out, to be reused in ApiQueryFilearchive
Simplified too per Bryan on IRC
Chad Horohoe [Sun, 6 Mar 2011 19:52:23 +0000 (19:52 +0000)]
(bug 26690) Value of the 'Name of wiki' field is not retain after two subsequent click on 'Continue' button. This has been a complaint since the beginning, that the installer "forgets" $wgSitename.
The original intention, as I saw it, was to encourage people from choosing 'MediaWiki' as the name of their wiki. Just hardcode it, I don't think we're changing the name anytime soon.
Chad Horohoe [Sun, 6 Mar 2011 19:34:57 +0000 (19:34 +0000)]
i18n tweaks for r83395
Chad Horohoe [Sun, 6 Mar 2011 19:25:18 +0000 (19:25 +0000)]
(bug 27903) Button text is actually continue, not next
Sam Reed [Sun, 6 Mar 2011 19:15:07 +0000 (19:15 +0000)]
* (bug 27717) API's exturlusage module does not respect $wgMiserMode
Implement ApiQueryCategoryMembers style miser mode stuffs
Sam Reed [Sun, 6 Mar 2011 18:17:28 +0000 (18:17 +0000)]
Fix leading whitespace before class ApiQueryUsers
Sam Reed [Sun, 6 Mar 2011 18:16:44 +0000 (18:16 +0000)]
Followup r83390, change cache modes
Chad Horohoe [Sun, 6 Mar 2011 18:12:30 +0000 (18:12 +0000)]
(bug 27901) Missing php version in config-using531 msg
Sam Reed [Sun, 6 Mar 2011 17:59:08 +0000 (17:59 +0000)]
* (bug 27897) list=allusers and list=users list hidden users
Refactored addition of block information, and also checked if user is allowed to view hidden user fields
Antoine Musso [Sun, 6 Mar 2011 17:36:42 +0000 (17:36 +0000)]
PHPUnit coverage comment must not have parentheses
Those comments have the format:
@covers Class::Method
In PHPUnit 3.5.12, the comment is split by :: and method_exist called on
the resulting string. When one use Class::Method(), the result is a call
to method_exist( 'Method()' ) which is always false and raise an exception
Removing parentheses from r79118 solve the issue. This also kind of
revert r79164.
Alexandre Emsenhuber [Sun, 6 Mar 2011 16:51:56 +0000 (16:51 +0000)]
Fix for r78512: set the default value to "view" for the action parameter
Krinkle [Sun, 6 Mar 2011 14:34:10 +0000 (14:34 +0000)]
Fixed (bug 27652) [jQuery.client] versionBase is wrong for versions higher with two or more digits
* A userAgent like the following:
> "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; nl-nl) AppleWebKit/533.19.4 (KHTML, like Gecko) Version/5.0.3 Safari/533.19.4"
Will now have a versionBase of "10" instead of "1".
* A few JSHint warnings fixed (missing semicolon)
Brian Wolff [Sun, 6 Mar 2011 09:14:04 +0000 (09:14 +0000)]
(follow-up: r83371) Fix variable name typo. $this to $loginForm.
Max Semenik [Sun, 6 Mar 2011 09:01:19 +0000 (09:01 +0000)]
Fixed fatals in UploadFromUrlTest. It still fails though
Brian Wolff [Sun, 6 Mar 2011 08:15:49 +0000 (08:15 +0000)]
(bug 27508) SVGMetadataExtractor takes too much resources on huge svg's. Change it so it only looks at begining of file.
Add a new config variable $wgSVGMetadataCutoff (currently set to 256kb, chosen rather arbitrarily)
and only read that much of the svg file when finding metadata. In general:
*Most (non-crazy huge map) svgs aren't that big, so there'd be no change in general
*Almost all files have any relevent metadata (well except for when we look for animation tags) is at the begining of the file
before actual image data.
*At the end of the day, even if this does miss metadata in some files (which I really doubt it would), I'd consider that a better
situation then the current situation where it can take 10 minutes or have OOM to parse the likes of [[:File:Puerto_Rico_ecosystems_map-fr.svg]]
Also has parts of/parts are based on Hartman's patch from bugzilla in it.
Also changes how it recurses into child elements looking for animation, to do so only when neccesary.
Trims the results of reading values, because i was getting extra leading spaces when testing this.
Last of all, add a comment to the MediaHandler class about how the first parameter of MediaHandler::getMetadata is kind of useless.
(it confused me when I was doing this)
Jack D. Pond [Sun, 6 Mar 2011 06:07:14 +0000 (06:07 +0000)]
Documentation updates for r83371
Jack D. Pond [Sun, 6 Mar 2011 05:39:41 +0000 (05:39 +0000)]
Fix and Enhance:
1. Fix - previously unresolved possible return value (ABORTED) added to switch
2. Allows a message to be returned when status "ABORTED" instead of just one of existing generic messages.
Brian Wolff [Sun, 6 Mar 2011 04:13:46 +0000 (04:13 +0000)]
If $wgEnotifMinorEdits=false, the enotifminoredits pref does nothing, so put it in $wgHiddenPrefs.
Its confusing to have it as an option, if its disabled, especially since there is no indication to the
user that it is disabled.
Brian Wolff [Sun, 6 Mar 2011 02:43:24 +0000 (02:43 +0000)]
(bug 27854) Http::isValidURI is way to lax. This is a much simplified regex that accepts a subset of the previous
regex, but also accepts ftps because both cURL and php support it. It no longer accepts thing like 'foo http://bar bax'
which was my main concern
Note the previous regex kind of looks more restrictive, but is not since saying "anything not containing a space
optionally followed by anything not containing a bunch of characters including a space" is the same as saying anything
with no spaces. See also r83296. This obviously doesn't catch all cases, but I personally think its sufficient.
At the very least it is a very significant improvement over the previous version that caught almost nothing.
Antoine Musso [Sat, 5 Mar 2011 22:26:09 +0000 (22:26 +0000)]
Use 'Courier new' for $wgShowDebug HTML output
'Courier new' is rendered with a constant size in both monobook
and vector skins. monospace is rendered too small under vector
with firefox/Linux.
Thus, this patch makes the font size consistent.
Alexandre Emsenhuber [Sat, 5 Mar 2011 19:49:24 +0000 (19:49 +0000)]
* NS_SPECIAL should not have any applicable restriction type
* Removed some trailing whitespaces
Bryan Tong Minh [Sat, 5 Mar 2011 19:47:04 +0000 (19:47 +0000)]
Follow-up r83218: Added var declarations. Html escape the largefileserver message. Introduced mediaWiki.Message.escaped() to bring the interface up to date with the PHP Message interface.
Raimond Spekking [Sat, 5 Mar 2011 19:28:25 +0000 (19:28 +0000)]
Follow-up r83218: Fix bug# per mediawiki.org/wiki/Special:Code/MediaWiki/83218#c14635
Jeroen De Dauw [Sat, 5 Mar 2011 19:22:43 +0000 (19:22 +0000)]
keep checkbox state when adding cat/ns pages
Raimond Spekking [Sat, 5 Mar 2011 19:12:05 +0000 (19:12 +0000)]
Follow-up r83292: Messages of the type foo.css are optional to translate.
Krinkle [Sat, 5 Mar 2011 19:00:19 +0000 (19:00 +0000)]
Fix bug in makeCollapsible.
* The instantHide implementation (added in r82471) didn't cover the case where a table is collapsed by default, it needs to pass the toggle to the function so that the row it is in can be excluded.
* The bug was found by user Helder.wiki, also reproducable on the demonstration page (I guess it was cached for everyone, since nobody noticed?)
* Demonstration page has been refreshed and all tests are passed now.
Chad Horohoe [Sat, 5 Mar 2011 18:32:37 +0000 (18:32 +0000)]
Fixup to schema help, there's only one now
Alexandre Emsenhuber [Sat, 5 Mar 2011 17:55:21 +0000 (17:55 +0000)]
Follow-up r83240: seems people prefer returning false than the current version when no revision with given ID is found
Antoine Musso [Sat, 5 Mar 2011 17:30:33 +0000 (17:30 +0000)]
tests for IP class, mostly incompletes
* IP::sanitizeIP()
* IP::canonicalize()
* IP::isInRange()
Bryan Tong Minh [Sat, 5 Mar 2011 17:23:35 +0000 (17:23 +0000)]
(bug 27018) Added action=filerevert to revert files to an old version. Copied procedure from FileRevertForm, as most of the verification procedure is simple enough to not warrant the effort of writing a dedicated backend.
Further changes:
* Added Status::getErrorsByType() which returns the internal error array untouched
* Added ApiResult::convertStatusToArray() which converts a Status object to something useful for the Api
Sam Reed [Sat, 5 Mar 2011 17:13:13 +0000 (17:13 +0000)]
Normalise table column ordering against ImagePage
Happy-melon [Sat, 5 Mar 2011 17:06:42 +0000 (17:06 +0000)]
Follow-up r83280; looks like I accidentally deprecated a piece of legacy JS :D
Sam Reed [Sat, 5 Mar 2011 17:01:33 +0000 (17:01 +0000)]
Explicit variables, documentation, newlines, braces
Happy-melon [Sat, 5 Mar 2011 16:51:13 +0000 (16:51 +0000)]
HTMLFormField class to build a select-dropdown-with-additional-text-field structure, with the select options maybe parsed from a system message as is done for the protect, block, delete, fileupload, etc, dialogues. Serves as a replacement vector for Xml::listDropDown().
Max Semenik [Sat, 5 Mar 2011 16:32:32 +0000 (16:32 +0000)]
Fix E_STRICT
Antoine Musso [Sat, 5 Mar 2011 16:15:39 +0000 (16:15 +0000)]
Tests for bug 27854 - Http::isValidURI is to lax
Those tests are made to help someone fix bug 27854. You might want to add
some more. Please note we want this function to only validate curl supported
URI, hence the hardcoded protocols http,https and ftp.
Some of those tests currently fail because of bug 27854.
Max Semenik [Sat, 5 Mar 2011 16:09:10 +0000 (16:09 +0000)]
Don't dupe/drop parts of searchindex on SQLite
Happy-melon [Sat, 5 Mar 2011 16:01:25 +0000 (16:01 +0000)]
Include MediaWiki:Noscript.css in <noscript></noscript> tags in the header, to allow wikis to load styles for users with JS disabled.
Max Semenik [Sat, 5 Mar 2011 15:44:28 +0000 (15:44 +0000)]
MediaWikiTestCase: factored prefix generation to a separate function
Bryan Tong Minh [Sat, 5 Mar 2011 15:14:49 +0000 (15:14 +0000)]
Follow-up r83286: detabify description for mediatype
Bryan Tong Minh [Sat, 5 Mar 2011 15:00:23 +0000 (15:00 +0000)]
(bug 27587) list=filearchive now outputs full title info
Krinkle [Sat, 5 Mar 2011 14:56:57 +0000 (14:56 +0000)]
Follow-up r83284. Fixing JSLint warnings: No need to escape a pipe (|) but a caret (^) should be escaped
Bryan Tong Minh [Sat, 5 Mar 2011 14:56:49 +0000 (14:56 +0000)]
(bug 27590) prop=imageinfo now allows querying the media type
Bryan Tong Minh [Sat, 5 Mar 2011 14:47:11 +0000 (14:47 +0000)]
Follow-up r83282: Re-add the lost $this->getNamespace() == NS_FILE, forgot to test the code for normal pages.
Krinkle [Sat, 5 Mar 2011 14:46:43 +0000 (14:46 +0000)]
Fixed (bug 27848) Escape '-' in $.escapeRE()
Bryan Tong Minh [Sat, 5 Mar 2011 14:44:28 +0000 (14:44 +0000)]
Move the file related parts of Title::isValidMoveOperation to its own function, Title::validateFileMoveOperation
Happy-melon [Sat, 5 Mar 2011 12:48:32 +0000 (12:48 +0000)]
Follow-up r83183, r83202:
* Update SpecialCheckUser.php to new location of IP functions
* Spin out the 'hide-other-field-if-select-box-not-on-other' function as one which should apply to all such fields, especially those created via HTMLForm. SpecialBlockip and SpecialGlobalBlock should ultimately be converted to use HTMLForm anyway.
Brian Wolff [Sat, 5 Mar 2011 03:35:49 +0000 (03:35 +0000)]
(bug 27862; follow-up r77714) Make emailuser api module not freak out when SpecialEmailUser returns a status object instead of true.
Platonides [Fri, 4 Mar 2011 22:52:20 +0000 (22:52 +0000)]
If the unknown element is empty, there won't be a matching END_ELEMENT. There's nothing to peek inside.
Brian Wolff [Fri, 4 Mar 2011 22:21:48 +0000 (22:21 +0000)]
trim the upload_by_url field from upload form, since if you have an extra space at the beggining like I
did when copying and pasting a url, gives a really misleading error message.
Bryan Tong Minh [Fri, 4 Mar 2011 21:57:23 +0000 (21:57 +0000)]
Fix and make file moving better resilient against errors by first copying the files, then doing the db updates and finally cleaning up the source.
* FsRepo::cleanupBatch now accepts either pairs, virtual urls and real paths
* Add missing begin() and commit() to LocalFileMoveBatch
* Actually set an error after incrementing failCount because otherwise the status is still good
* Changed some isOk() to isGood() and set ->ok explicitly to false after rollback
Alexandre Emsenhuber [Fri, 4 Mar 2011 20:16:35 +0000 (20:16 +0000)]
* (bug 27763) Article::getParserOutput() no longer throws a fatal given when an incorrect revision ID is passed
Raimond Spekking [Fri, 4 Mar 2011 20:06:34 +0000 (20:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-04 19:51:00 UTC)
Mark A. Hershberger [Fri, 4 Mar 2011 19:19:59 +0000 (19:19 +0000)]
followup r83227 ... missed bits of patch
Mark A. Hershberger [Fri, 4 Mar 2011 19:13:59 +0000 (19:13 +0000)]
W/S cleanup
Brian Wolff [Fri, 4 Mar 2011 19:08:21 +0000 (19:08 +0000)]
(bug 27825) Make the raw watchlist edit messages use formatNum.
Hopefully i added to the right section of RELEASE-NOTES. Wasn't sure.
Mark A. Hershberger [Fri, 4 Mar 2011 18:25:21 +0000 (18:25 +0000)]
* Bug 27823 - Re-enable functionality of --uploads option of importDump.php; introduce --namespaces filter option for importDump.php
Patch from Dmitriy Sintsov of which he writes:
I needed to selectively import files from URL's defined in
previousely made XML dump. This worked fine in 1.15, but to my
surprise wasn't working with 1.17, producing an error. I've
partially fixed upload code (including supplying of original User
instance for local upload) and introduced new option to
selectively import only the listed namespaces in importDump.php
command line.
Antoine Musso [Fri, 4 Mar 2011 17:16:09 +0000 (17:16 +0000)]
Underscore are not valid in language code
* Reject underscore in validation
* Still case unsensitive
* Corrected tests using underscore
Follow up r83160 which was a follow up of r82927 (language code validation)
Bryan Tong Minh [Fri, 4 Mar 2011 15:38:37 +0000 (15:38 +0000)]
(bug 26995) File size is now checked before uploading in HTML5 browsers
* Exposed $wgMaxUploadSize to JS
* Exposed message largefileserver to JS
Chad Horohoe [Fri, 4 Mar 2011 13:58:40 +0000 (13:58 +0000)]
(bug 27781) Pt 2: Check for minimum PHP version in installer (which is seperate from the PHP4 check)
Chad Horohoe [Fri, 4 Mar 2011 13:17:13 +0000 (13:17 +0000)]
Cleanup r83022: just use IGNORE